New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ARKit] Update framework to Xcode 12 beta 5. #9402
[ARKit] Update framework to Xcode 12 beta 5. #9402
Conversation
Adding as a draft until we get the bump, but is a good way to move fwd while we wait for bots. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The .todo
needs to be editing and it is not empty (previous beta?)
!missing-pinvoke! ARSkeletonJointNameForRecognizedPointKey is not bound
f2b45d3
to
f7e01a3
Compare
Build failure |
Build failure |
f7e01a3
to
24a85ef
Compare
24a85ef
to
ee3777e
Compare
public void UnknonwPointTest () | ||
{ | ||
using (var notKnownPoint = new NSString ("nariz")) | ||
Assert.IsNull (ARSkeleton.CreateJointName (notKnownPoint)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't add the success until visio is done, tracked here: #9420
[Preserve (AllMembers = true)] | ||
public class ARSkeletonTest { | ||
[Test] | ||
public void UnknonwPointTest () |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor: typo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
public void UnknonwPointTest () | |
public void UnknownPointTest () |
src/ARKit/ARSkeleton.cs
Outdated
[DllImport (Constants.ARKitLibrary)] | ||
static extern IntPtr /* NSString */ ARSkeletonJointNameForRecognizedPointKey (/* NSString */ IntPtr recognizedPointKey); | ||
|
||
[EditorBrowsable (EditorBrowsableState.Advanced)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's the normal alternative ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use the enum from Visio or use the smart enum ARSkeletonJointName rather than create one from the key
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I get that :-) but I mean what's the method/API alternative that the IDE won't try to hide from the developer ?
We normally use Advanced
because there's a simpler/nicer alternative that we want developers to use (over the more complex one).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need visio for that, I have create issue #9432
nuint GetJointIndex (NSString? jointName); | ||
|
||
[Wrap ("GetJointIndex (jointName.GetConstant()!)")] | ||
nuint GetJointIndex (ARSkeletonJointName jointName); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what was the reason to remove [BindAs]
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because the new added C API allows to create new ARSkeletonJointName which are a typedef based on NSString, if we hide it then the new API makes so sense. The new binding exposes the NSString option as an advance option and then adds the wrap for our smart enum.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make sense, copy/paste that into the commit message before merging :)
Build failure |
Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>
Build success |
No description provided.